Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deletion order. #154

Merged
merged 4 commits into from
Jan 2, 2021
Merged

Implement deletion order. #154

merged 4 commits into from
Jan 2, 2021

Conversation

davidkarlsen
Copy link
Collaborator

@davidkarlsen davidkarlsen commented Jan 2, 2021 •
edited
Loading

Fixes #138

@davidkarlsen davidkarlsen changed the title Implement deletion order. Fixes #138 Implement deletion order. Jan 2, 2021
@davidkarlsen davidkarlsen self-assigned this Jan 2, 2021
@davidkarlsen davidkarlsen added this to the v0.8.0 milestone Jan 2, 2021
@codecov
Copy link

codecov bot commented Jan 2, 2021 •
edited
Loading

Codecov Report

Merging #154 (06b32cd) into master (1c405cf) will increase coverage by 0.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   61.14%   62.13%   +0.99%     
==========================================
  Files           2        2              
  Lines         193      198       +5     
==========================================
+ Hits          118      123       +5     
  Misses         55       55              
  Partials       20       20
Impacted Files Coverage Δ
controllers/githubactionrunner_controller.go 54.82% <100.00%> (ø)
controllers/podrunner_types.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c405cf...06b32cd. Read the comment docs.

@davidkarlsen davidkarlsen merged commit 386ba1a into master Jan 2, 2021
@davidkarlsen davidkarlsen deleted the deletionOrder branch January 2, 2021 23:11
@davidkarlsen davidkarlsen added the enhancement New feature or request label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidkarlsen davidkarlsen

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Sort pods for deletion based on configurable policy
1 participant
@davidkarlsen